Add non-coroutine Swoole HTTP server adapter#229
Closed
ChiragAgg5k wants to merge 1 commit into0.34.xfrom
Closed
Conversation
Add HttpServer adapter class that wraps Swoole\Http\Server for users who need the traditional multi-process server with worker management and graceful reload, as an alternative to the existing coroutine-based Server adapter. Both adapters implement the same Adapter contract and are interchangeable.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpServeradapter class wrappingSwoole\Http\Serverfor the traditional multi-process server model with worker management and graceful reloadon('request')/on('start')event-based API instead of coroutinehandle()/ immediate callbackServeradapter via theAdaptercontractTest plan
Server,Adapter, orHttp)tests/e2e/server-swoole-http.phpboots and serves requests withHttpServerHttpclass works with bothServerandHttpServerinterchangeably